CI: -j4 with lin/win runners [RELEASE] #9637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plowsof
force-pushed
the
release-v0.18
branch
from
ffa9a31 to
d5689c3
Compare
plowsof
force-pushed
the
release-v0.18
branch
from
d5689c3 to
a20c68e
Compare
selsta
approved these changes
Dec 23, 2024
tobtoht
approved these changes
Dec 24, 2024
0xFFFC0000
approved these changes
Dec 25, 2024
vtnerd
suggested changes
Dec 31, 2024
| @@ -11,7 +11,7 @@ on: | |||
| env: | |||
| REMOVE_BUNDLED_BOOST : rm -rf /usr/local/share/boost | |||
| BUILD_DEFAULT_LINUX: | | |||
| cmake -S . -B build -D ARCH="default" -D BUILD_TESTS=ON -D CMAKE_BUILD_TYPE=Release && cmake --build build -j3 | |||
| cmake -S . -B build -D ARCH="default" -D BUILD_TESTS=ON -D CMAKE_BUILD_TYPE=Release && cmake --build build --parallel 4 | |||
There was a problem hiding this comment.
I think this could be --parallel $(nproc) which future proofs things a bit. Not sure if this works with msys. macOS is a pain to do something similar.
There was a problem hiding this comment.
The rules here are a bit more complicated because there's also a memory requirement: see #9510 (comment) (and subsequent discussion). I have a commit ready to PR which accounts for all the requirements, but I'm waiting for this one (and the corresponding main branch PR) to get merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.